[philips-hue] Answer message when no lights found in a room #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cicoub13
changed the title
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
=======================================
Coverage 94.39% 94.40%
=======================================
Files 481 481
Lines 6355 6362 +7
=======================================
+ Hits 5999 6006 +7
Misses 356 356
Continue to review full report at Codecov.
|
Pierre-Gilles
requested changes
Nov 19, 2020
- Do not check number of devices but number of devices with binary features
Pierre-Gilles
requested changes
Nov 20, 2020
atrovato
suggested changes
Nov 21, 2020
atrovato
approved these changes
Nov 21, 2020
Pierre-Gilles
approved these changes
Nov 23, 2020
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…s been found (GladysAssistant#965) * fix: Answer message when no lights found in a room Closes GladysAssistant#959 * fix: Take in account PR feedbacks - Do not check number of devices but number of devices with binary features * fix(philips-hue): Use case where exception is thrown and no lights Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #959
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)npm run compare-translationson front) => Not applicablefront/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com. => Not applicableNOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Fix issue #959 when asking to turn on/off lights in a room with no lights