Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[philips-hue] Use MarkupText for error on Philips Hue Setup Page #967

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

cicoub13
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests? => Not applicable
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front) => Not applicable
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) => Not applicable
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website. => Not applicable
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com. => Not applicable

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Use MarkupText for error on Philips Hue Setup Page to render html

@cicoub13
Copy link
Contributor Author

For information, I checked all the other texts containing HTML and they are well displayed in a MarkupText.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #967 (991c830) into master (174aa0d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files         462      462           
  Lines        6133     6133           
=======================================
  Hits         5779     5779           
  Misses        354      354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174aa0d...8858c54. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 0702f4a into GladysAssistant:master Nov 20, 2020
@cicoub13 cicoub13 deleted the fix-951 branch November 20, 2020 14:21
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…ladysAssistant#967)

Closes GladysAssistant#951

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants