Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience of calendar service #975

Merged
merged 7 commits into from
Nov 27, 2020
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Nov 23, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Make the calendar service more strong by not crashing if the insert of one event fails

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #975 (cbb0ced) into master (d14b141) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
+ Coverage   94.49%   94.51%   +0.01%     
==========================================
  Files         485      485              
  Lines        6435     6438       +3     
==========================================
+ Hits         6081     6085       +4     
+ Misses        354      353       -1     
Impacted Files Coverage Δ
...services/caldav/lib/calendar/calendar.formaters.js 90.62% <ø> (-0.15%) ⬇️
.../caldav/lib/calendar/calendar.syncUserCalendars.js 100.00% <100.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14b141...cbb0ced. Read the comment docs.

@Pierre-Gilles Pierre-Gilles changed the title WIP: Improve resilience of calendar service Improve resilience of calendar service Nov 27, 2020
@Pierre-Gilles Pierre-Gilles merged commit abb17b3 into master Nov 27, 2020
@Pierre-Gilles Pierre-Gilles deleted the fix-calendar-service branch November 27, 2020 12:08
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
* Add Promise.map + try catch around single insert of event

* change all Promise.all in Promise.map

* event selector should be unique

* Fix eslint

* Fix tests

* Add test on updateEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant