Skip to content

Commit

Permalink
fix(information_schema): identity_cycle, is_updatable (#2616)
Browse files Browse the repository at this point in the history
Noticed these typos while doing something else...just a hygiene skim,
and not the result of some error from a pg integration.

Taken from
https://www.postgresql.org/docs/current/infoschema-columns.html#INFOSCHEMA-COLUMNS.

From that spec, we are additionally missing the column
`character_octet_length`, which seems like it should be derived as 0 or
`null` based on whether `c.data_type` is character-based, though maybe
just passing in `null` or even omitting it for now is fine?
  • Loading branch information
greyscaled authored and tychoish committed Feb 15, 2024
1 parent 7db7437 commit 3f77859
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/sqlbuiltins/src/builtins.rs
Original file line number Diff line number Diff line change
Expand Up @@ -464,10 +464,10 @@ SELECT
null AS identity_increment,
null AS identity_maximum,
null AS identity_minimum,
null AS identity_cyle,
null AS identity_cycle,
null AS is_generated,
null AS generation_expression,
'NO' AS is_updateable
'NO' AS is_updatable
FROM glare_catalog.columns c
INNER JOIN glare_catalog.schemas s ON c.schema_oid = s.oid
INNER JOIN glare_catalog.databases d ON s.database_oid = d.oid
Expand Down

0 comments on commit 3f77859

Please sign in to comment.