fix(deps): remove dynamic linking to 'lzma' (#2631)

GlareDB · Feb 9, 2024 · 4814ab7 · 4814ab7
1 parent 0671822
commit 4814ab7
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/benchmarks/tpch/requirements.txt b/benchmarks/tpch/requirements.txt
@@ -1,6 +1,6 @@
 maturin==1.0.1
 virtualenv==20.23.1
-ruff==0.0.275
+ruff==0.2.1
 black==23.3.0
 blackdoc==0.3.8
 mypy==1.3.0

diff --git a/bindings/nodejs/Cargo.toml b/bindings/nodejs/Cargo.toml
@@ -34,6 +34,8 @@ bytes = "1.5.0"
 serde.workspace = true
 serde_json.workspace = true
 
+# Prevent dynamic linking of lzma, which comes from datafusion
+lzma-sys = { version = "*", features = ["static"] }
 
 [build-dependencies]
 napi-build = "2.1.0"
diff --git a/bindings/python/Cargo.toml b/bindings/python/Cargo.toml
@@ -33,3 +33,6 @@ futures = { workspace = true }
 uuid = "1.7.0"
 async-trait = { workspace = true }
 once_cell = "1.19.0"
+
+# Prevent dynamic linking of lzma, which comes from datafusion
+lzma-sys = { version = "*", features = ["static"] }
diff --git a/crates/glaredb/Cargo.toml b/crates/glaredb/Cargo.toml
@@ -49,6 +49,9 @@ tokio-postgres = "0.7.8"
 uuid = { version = "1.7.0", features = ["v4", "fast-rng", "macro-diagnostics"] }
 glob = "0.3.1"
 
+# Prevent dynamic linking of lzma, which comes from datafusion
+lzma-sys = { version = "*", features = ["static"] }
+
 [dev-dependencies]
 predicates = "3.1.0"
 assert_cmd = "2.0.13"

diff --git a/tests/tests/test_smoke.py b/tests/tests/test_smoke.py
@@ -51,7 +51,7 @@ def test_expected_linking_linux(debug_path: pathlib.Path):
         )
     ]
     expected_prefix = ["libc.so", "libm.so", "linux-vdso"]
-    possible_libs = ["liblzma", "libbz", "libgcc"]
+    possible_libs = ["libbz", "libgcc"]
     pending_removal = ["libcrypto", "libssl"]
     expected = 0
     possible = 0