Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --logs flag to local command #1357

Closed
vrongmeal opened this issue Jul 21, 2023 · 1 comment · Fixed by #2187
Closed

Add --logs flag to local command #1357

vrongmeal opened this issue Jul 21, 2023 · 1 comment · Fixed by #2187
Labels
feat 🎇 New feature or request good first issue 🆕 Good issues for newcomers or new hires

Comments

@vrongmeal
Copy link
Contributor

Description

We can specify a file (or even stdout/stderr) for logs when running local mode.

glaredb local --logs debug.log

Rationale

Helpful while debugging and figuring out errors (for user).

Breaking effects
@vrongmeal vrongmeal added the feat 🎇 New feature or request label Jul 21, 2023
@adhish20 adhish20 assigned adhish20 and unassigned adhish20 Jul 21, 2023
@universalmind303 universalmind303 added the good first issue 🆕 Good issues for newcomers or new hires label Sep 11, 2023
@Lilit0x
Copy link
Contributor

Lilit0x commented Dec 1, 2023

Hi @universalmind303, can I work on this?

@Lilit0x Lilit0x mentioned this issue Dec 1, 2023
Merged
scsmithr pushed a commit that referenced this issue Dec 8, 2023
@Lilit0x @vrongmeal
feat: add --logs flag to local command (#2187)
45dcc23 
Added `--logs` subcommand to local command. Defaults to `debug.log` when
no file is provided.
Closes: #1357

---------

Co-authored-by: Vaibhav Rabber <vrongmeal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat 🎇 New feature or request good first issue 🆕 Good issues for newcomers or new hires
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --logs flag to local command Lilit0x/glaredb
4 participants
@adhish20 @universalmind303 @vrongmeal @Lilit0x