Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters for read_excel are empty #2373

Closed
greyscaled opened this issue Jan 8, 2024 · 0 comments · Fixed by #2376
Closed

Parameters for read_excel are empty #2373

greyscaled opened this issue Jan 8, 2024 · 0 comments · Fixed by #2376
Assignees
@universalmind303
Labels
bug Something isn't working

Comments

@greyscaled
Copy link
Contributor 

> select function_name, parameters from glare_catalog.functions WHERE function_name = 'read_excel';
┌───────────────┬────────────┐
│ function_name │ parameters │
│ ──            │ ──         │
│ Utf8          │ List<Utf8> │
╞═══════════════╪════════════╡
│ read_excel    │ []         │
└───────────────┴────────────┘
>
@greyscaled greyscaled added the bug Something isn't working label Jan 8, 2024
@greyscaled greyscaled mentioned this issue Jan 8, 2024
Merged
@universalmind303 universalmind303 mentioned this issue Jan 8, 2024
Merged
universalmind303 added a commit that referenced this issue Jan 8, 2024
@universalmind303
fix: add signature for read_excel (#2376)
44c28f8 
closes #2373 

```sql
> select function_name, parameters from glare_catalog.functions WHERE function_name = 'read_excel';
┌───────────────┬─────────────────────────────────────────────────────────────────────────┐
│ function_name │ parameters                                                              │
│ ──            │ ──                                                                      │
│ Utf8          │ List<Utf8>                                                              │
╞═══════════════╪═════════════════════════════════════════════════════════════════════════╡
│ read_excel    │ [Utf8, Utf8, sheet_name: Utf8, infer_rows: UInt64, has_header: Boolean] │
└───────────────┴─────────────────────────────────────────────────────────────────────────┘
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@universalmind303 universalmind303

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add signature for read_excel GlareDB/glaredb
2 participants
@greyscaled @universalmind303