Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank gh release notes being published #2399

Closed
greyscaled opened this issue Jan 10, 2024 · 0 comments · Fixed by #2740
Closed

Remove blank gh release notes being published #2399

greyscaled opened this issue Jan 10, 2024 · 0 comments · Fixed by #2740
Labels
bug Something isn't working build Build or release related ci Related to CI/CD

Comments

@greyscaled
Copy link
Contributor

greyscaled commented Jan 10, 2024

Release notes are automatically published (public). The author is github-actions. We prefer drafting them from a tag and releasing them manually.

Reference: (notice the author) - https://github.com/GlareDB/glaredb/releases/tag/v0.8.0

This can create subtle bugs in installing the CLI, since the install.sh script looks for target binaries in our latest release, and if a blank release is getting published, they won't exist. There could be a case where we have drafted full release notes, and can't publish them (without realizing) and what we're instead left with is a blank release.

The notes initially come out blank. If the release manager already had a draft in progress, it can no longer be published since there can only be 1 release for any given tag.


The desired process:

  • release notes are drafted from a tag
  • release actions build and distribute binaries
  • we publish the notes with the binaries when all checks have passed and we're ready to go live
@greyscaled greyscaled added chore DX, infra etc that's not build or CI related build Build or release related ci Related to CI/CD and removed chore DX, infra etc that's not build or CI related labels Jan 10, 2024
@greyscaled greyscaled changed the title Remove automation for release being published Remove blank gh release notes being published Jan 11, 2024
@greyscaled greyscaled added the bug Something isn't working label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build or release related ci Related to CI/CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant