Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zero value timestamps #2438

Closed
scsmithr opened this issue Jan 17, 2024 · 0 comments
Closed

Handle zero value timestamps #2438

scsmithr opened this issue Jan 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@scsmithr
Copy link
Member

Description

0001-01-01 00:00:00

This doesn't fit in nanosecond precision, so our current timestamp handling won't accommodate reading zero value timestamps from external sources.

@scsmithr scsmithr added the bug Something isn't working label Jan 17, 2024
vrongmeal added a commit that referenced this issue Jan 30, 2024
```
> select * from read_postgres('postgresql://glaredb:password@0.0.0.0:5433/glaredb_test', 'public', 'abc');
┌─────────────────────┐
│ a                   │
│ ──                  │
│ Timestamp<µs, UTC>  │
╞═════════════════════╡
│ 0001-01-01T00:00:00 │
└─────────────────────┘
```

Fixes: #2438

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
vrongmeal added a commit that referenced this issue Jan 31, 2024
```
> select * from read_postgres('postgresql://glaredb:password@0.0.0.0:5433/glaredb_test', 'public', 'abc');
┌─────────────────────┐
│ a                   │
│ ──                  │
│ Timestamp<µs, UTC>  │
╞═════════════════════╡
│ 0001-01-01T00:00:00 │
└─────────────────────┘
```

Fixes: #2438

---------

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
tychoish pushed a commit that referenced this issue Feb 1, 2024
```
> select * from read_postgres('postgresql://glaredb:password@0.0.0.0:5433/glaredb_test', 'public', 'abc');
┌─────────────────────┐
│ a                   │
│ ──                  │
│ Timestamp<µs, UTC>  │
╞═════════════════════╡
│ 0001-01-01T00:00:00 │
└─────────────────────┘
```

Fixes: #2438

---------

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant