Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Enable altering views through the ALTER TABLE function #2676

Closed
talagluck opened this issue Feb 21, 2024 · 1 comment · Fixed by #2678
Closed

Bug: Enable altering views through the ALTER TABLE function #2676

talagluck opened this issue Feb 21, 2024 · 1 comment · Fixed by #2678
Labels
bug Something isn't working

Comments

@talagluck
Copy link
Contributor

talagluck commented Feb 21, 2024 •
edited
Loading

Description

I'm hitting an issue with dbt where it works fine for tables but panics when it hits views.

I just did a round of debugging with @scsmithr and it seems like the issue is that it's running an ALTER TABLE function to rename a view. Looking for two things here:

  1. ALTER TABLE should work on views for renaming views
  2. Don't panic
@talagluck talagluck added the bug Something isn't working label Feb 21, 2024
@scsmithr
Copy link
Member

scsmithr commented Feb 21, 2024 •
edited
Loading

Specifically panicking here: https://github.com/glaredb/glaredb/blob/db252ce59d066e073b40be0d30eecc30f61a130e/crates/metastore/src/database.rs#L938-L941 (on the unreachable)

vrongmeal added a commit that referenced this issue Feb 21, 2024
@vrongmeal
fix: Alter table renames view successfully
bc4a929 
Fixes: #2676

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal vrongmeal mentioned this issue Feb 21, 2024
Merged
vrongmeal added a commit that referenced this issue Feb 21, 2024
@vrongmeal
fix: Alter table renames view successfully (#2678)
f7206bd 
Fixes: #2676

---------

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Alter table renames view successfully GlareDB/glaredb
2 participants
@scsmithr @talagluck