-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data source from JSON array data #2306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm super excited about this!
I wonder if implementing the object store's file type ends up having you write more boilerplate than is needed.
I had great luck recently using the StreamingTable
infrastructure in the bson functionality, though I don't know if it makes a lot of sense (also your code supports gzipped inputs and the BSON code does not.)
You mean the
Hmm, I looked through it, I can't seem to see where and how it will fit this use case. Maybe I am missing something. |
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I think given that df419aa has landed, we should let this one drop. I think there's a lot of merit to this approach, and I'm super thankful that you did this work for us to learn from, and sorry that we didn't use the code directly. |
Closes: #2218
How to Test
SELECT * FROM read_arjson('path/to/file/or/urls', max_size, <creds>)