Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: speed up ci by introducing precompiled slt binary #2363

Merged
merged 29 commits into from
Jan 8, 2024
Merged

ci: speed up ci by introducing precompiled slt binary #2363

merged 29 commits into from
Jan 8, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Jan 5, 2024 •
edited
Loading

billable time & wall time are both down

Before

image
image

image

After

image

@universalmind303 universalmind303 requested review from tychoish, vrongmeal and scsmithr and removed request for tychoish January 6, 2024 00:22
@universalmind303
Copy link
Contributor Author

closes #2362

@universalmind303 universalmind303 linked an issue Jan 6, 2024 that may be closed by this pull request
chore(ci): move cassandra slt's to their own stage #2362
Closed
tychoish
tychoish reviewed Jan 6, 2024
View reviewed changes
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, a few questions really.

justfile Outdated Show resolved Hide resolved
justfile Show resolved Hide resolved
crates/testing/src/main.rs Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
scsmithr
scsmithr reviewed Jan 6, 2024
View reviewed changes
crates/testing/src/main.rs Outdated Show resolved Hide resolved
crates/testing/src/main.rs Outdated Show resolved Hide resolved
testdata/sqllogictests/functions/csv_scan.slt Outdated Show resolved Hide resolved
scsmithr
scsmithr reviewed Jan 8, 2024
View reviewed changes
crates/testing/src/slt/cli.rs Show resolved Hide resolved
testdata/sqllogictests/catalog/functions.slt Outdated Show resolved Hide resolved
testdata/sqllogictests/create_table.slt Outdated Show resolved Hide resolved
@universalmind303 universalmind303 mentioned this pull request Jan 8, 2024
Merged
scsmithr
scsmithr reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If passes, lgtm

@universalmind303 universalmind303 merged commit 72ab349 into main Jan 8, 2024
19 checks passed
@universalmind303 universalmind303 deleted the universalmind303/slt-ci branch January 8, 2024 21:16
@universalmind303 universalmind303 mentioned this pull request Jan 8, 2024
Closed
universalmind303 added a commit that referenced this pull request Jan 8, 2024
@universalmind303
feat: cassandra external database (#2374)
4b17c4a 
I realized I branched off `slt-ci` instead of main for this. So this
depends on #2363

closes #2346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scsmithr scsmithr scsmithr left review comments

@tychoish tychoish tychoish approved these changes

@vrongmeal vrongmeal Awaiting requested review from vrongmeal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(ci): move cassandra slt's to their own stage
3 participants
@universalmind303 @tychoish @scsmithr