Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Boolean datatypes after klickhouse switch #2407

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

vrongmeal
Copy link
Contributor

This can be extended for other datatypes as well now (relatively easily).

Thinking of forking klickhouse for our purpose. See the comment under Date32 for details.

@vrongmeal
Copy link
Contributor Author

@scsmithr can you try this out with clickhouse cloud once?

Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

> select * from ch.default.bools;
┌─────────┐
│ hi      │
│ ──      │
│ Boolean │
╞═════════╡
│ true    │
│ false   │
└─────────┘

@vrongmeal vrongmeal merged commit d86f20c into main Jan 11, 2024
19 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/klickhouse-datatypes branch January 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants