Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix pypi release #2557

Merged
merged 8 commits into from
Feb 1, 2024
Merged

ci: fix pypi release #2557

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a0e6ff4
ci fix: pypi release
universalmind303 Feb 1, 2024
8b81c72
use 13 instead of 14
universalmind303 Feb 1, 2024
af5a266
dry run
universalmind303 Feb 1, 2024
e727b0d
merge from main
universalmind303 Feb 1, 2024
afc97ca
remove cache
universalmind303 Feb 1, 2024
66bb7c8
fix merge
universalmind303 Feb 1, 2024
cc4bd64
done
universalmind303 Feb 1, 2024
cbb6c72
fix slack post
universalmind303 Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/python-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:


macos:
runs-on: macos-12-xl
runs-on: macos-13-xlarge
strategy:
fail-fast: true
matrix:
Expand All @@ -126,7 +126,7 @@ jobs:
- name: Build wheels
uses: PyO3/maturin-action@v1
with:
target: ${{ matrix.target }}
target: ${{ matrix.target }}-apple-darwin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, x86_64 and aarch64 arent valid targets, they should be they fully qualified ones aarch64-apple-darwin

https://www.maturin.rs/config#target-specific-maturin-options

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I noticed this in #2556 as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a recent change?

args: --release --out dist
working-directory: bindings/python
sccache: "true"
Expand Down
Loading