Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudauth): remove unused fields #2567

Merged
merged 3 commits into from
Feb 2, 2024
Merged

chore(cloudauth): remove unused fields #2567

merged 3 commits into from
Feb 2, 2024

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Feb 2, 2024

These are harmless to have around in the tests, but don't add value and may mislead someone in the future into expecting they exist on the actual response

These are harmless to have around, but don't add value and may mislead
someone in the future into expecting they exist on the response
@greyscaled greyscaled requested a review from tychoish February 2, 2024 02:42
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are both in tests, so might be fine to leave them in, just to make sure that the proxy doesn't break if cloud gives it information it isn't expecting, but also we could delete them or add a comment.

@greyscaled
Copy link
Contributor Author

these are both in tests, so might be fine to leave them in, just to make sure that the proxy doesn't break if cloud gives it information it isn't expecting, but also we could delete them or add a comment.

I'd be down to keep them with a comment for the reason of not requiring all fields in the response being mapped

@tychoish
Copy link
Contributor

tychoish commented Feb 2, 2024

I'd be down to keep them with a comment for the reason of not requiring all fields in the response being mapped

Whatever you like, I think it's probably fine either way.

@greyscaled greyscaled enabled auto-merge (squash) February 2, 2024 15:12
@greyscaled greyscaled merged commit f0e857f into main Feb 2, 2024
22 checks passed
@greyscaled greyscaled deleted the grey/cloudauth branch February 2, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants