feat: add object store table support for bson format data #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrongmeal
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
This looks good to me.
I looked into the FileType enum and it being a dependent on FileFormat trait. I think we should implement FileFormat for these formats. We can keep the file_type method as unreachable since that code-path is never used by us.
From slack ^
scsmithr
reviewed
Feb 22, 2024
|
|
||
| Ok(provider) | ||
| match file_type { | ||
| "csv" => Ok(accessor |
There was a problem hiding this comment.
Apparently the file type is getting stored with with quotes, so matching on "\"csv\"" works...
There was a problem hiding this comment.
I believe it's not getting stored as a quote but just printed into a quoted form when it's read which is easy enough clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maybe could also support lance in a similar sort of way, (which is
where I started when I was looking at this code, but I got this.)
Need to coordinate credentials to get some data uploaded to a gcs
bucet to test this.