Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unsigned integer types being cast to integers #2640

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

hemanth94
Copy link
Contributor

Fixes #2588

As Unsigned integers are downgraded to integers when stored in delta-lake. Adding metadata.
@universalmind303 This is similar to #2607 Kindly review.

Thanks,

@tychoish
Copy link
Contributor

@hemanth94 thanks for this contribution!

This makes sense. Is it possible to write a test for this?

@hemanth94
Copy link
Contributor Author

hemanth94 commented Feb 13, 2024

This makes sense. Is it possible to write a test for this?

Thank you, Sure I will try.

@tychoish tychoish enabled auto-merge (squash) February 13, 2024 17:59
@tychoish tychoish disabled auto-merge February 13, 2024 18:00
@tychoish tychoish enabled auto-merge (squash) February 13, 2024 18:01
@tychoish tychoish merged commit 564a3f0 into GlareDB:main Feb 13, 2024
22 checks passed
tychoish pushed a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsigned integers are cast to ints when creating tables
2 participants