chore: pytest path cleanup and port management #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talagluck
approved these changes
Mar 5, 2024
tests/test_dbt.py
Outdated
Comment on lines
84
to
98
| with tests.tools.env("GLAREDB_PORT", str(glaredb_connection.info.port)): | ||
| with tests.tools.env("DBT_USER", glaredb_connection.info.user): | ||
| res: dbtRunnerResult = dbtRunner().invoke( | ||
| [ | ||
| "run", | ||
| "--project-dir", | ||
| dbt_project_path, | ||
| "--profiles-dir", | ||
| dbt_project_path, | ||
| "-m", | ||
| model_name, | ||
| ] | ||
| ) | ||
|
|
||
| assert res.success is True |
There was a problem hiding this comment.
The nested with block looks kind of gnarly. Maybe something like this instead?
| @@ -4,9 +4,9 @@ glaredb_dbt_test: | |||
| dbname: default | |||
| host: 127.0.0.1 | |||
| pass: "" | |||
| port: 5432 | |||
| port: "{{ env_var('GLAREDB_PORT') | as_number }}" | |||
There was a problem hiding this comment.
This is a welcome improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two major changes:
we'll use either the release or the debug (in that order of
preference) build if they exist. If neither exists, 🤷, that seems
like a reasonable failure mode for integration tests. (Inspired by
pytests fail locally if
target/releaseis not available #2730)randomly select an unused port, and use that (rather than the
default postgres port.) this means we can run tests in parallel (and
doing so halves the runtime on my laptop.) This had been on my list
for a while, but I hadn't yet been bothered by the runtime.
Closes #2730