chore: add better regclass and oid cast support #2795
Conversation
| @@ -0,0 +1,30 @@ | |||
|
|
|||
| statement error | |||
There was a problem hiding this comment.
should we put the error message here?
| statement error Casting expressions to oid unsupported | ||
| select cast(1 as oid); | ||
|
|
||
| statement error Casting expressions to oid unsupported |
There was a problem hiding this comment.
should this error message be phrased as "only strings can be cast to OIDs"
There was a problem hiding this comment.
This error message was copied from the regclass error. I can change it, but used this to remain consistent with the existing implementation.
| select cast('my_table' as OID); | ||
|
|
||
|
|
||
| # We don't support expressions other than strings right now. |
There was a problem hiding this comment.
is there a point to supporting more ever/eventually?
There was a problem hiding this comment.
idk, most of this was copied from the regclass stuff, so i didn't want to change any more than absolutely necessary to implement the new functionality
IDK, aruguably it could also be a feature... |
|
The existing regclass error is only used once, and is ambiguous from the user's perspective (and ours, when debugging) if they ever run into it, particularly now that we (presumably) support integer and string casts. If it's easy enough to provide a bit more context, it seems worthwhile. I don't see any particular reason to treat our error messages as a stable API, unless I'm missing something or this is a standard/copied error message. |
partially addresses #2746