Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): fix napi argument #2808

Merged
merged 1 commit into from
Mar 20, 2024
Merged

chore(npm): fix napi argument #2808

merged 1 commit into from
Mar 20, 2024

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Mar 20, 2024

According to the print out here: https://github.com/GlareDB/glaredb/actions/runs/8363511181/job/22898484272#step:10:27

napi doesn't accept any args (=true in this case) for boolean flags.

@greyscaled greyscaled requested a review from tychoish March 20, 2024 18:42
@greyscaled greyscaled merged commit 8d8aefa into main Mar 20, 2024
25 checks passed
@greyscaled greyscaled deleted the grey/npm branch March 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants