fix: properly satisfy enforcesorting rules #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+289
to
+296
| fn required_input_ordering(&self) -> Vec<Option<Vec<PhysicalSortRequirement>>> { | ||
| // the input ordering must match the output ordering of the source | ||
| // without this, the sort may get removed by the optimizer | ||
| vec![self | ||
| .output_ordering() | ||
| .map(PhysicalSortRequirement::from_sort_exprs)] | ||
| } | ||
| } |
There was a problem hiding this comment.
the WriteOnlyDataSourceMetricsExecAdapter needs an explicit check on the input ordering, otherwise the EnforceSorting rule may remove it. The ReadOnly... doesn't care, so this needed to be split out.
This states that if the child has an explicit output_ordering, then this node needs a matching input_ordering.
universalmind303
changed the title
tychoish
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2811