Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate new rust sdk into python bindings #2850

Merged
merged 120 commits into from
Apr 18, 2024

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Apr 1, 2024

This is stuck in some borrow checker fun times. My attempt to collapse the PyLogicalPlan and the PyExecutionResult seems to have run into a wall.

The crux of the problem is that that:

  • PyObjects need to be + Clone + Sync
  • SendableRecordStream don't work with that, and all of my attempts to hack around this haven't succeeded.

tychoish added 30 commits March 20, 2024 17:32
Base automatically changed from tycho/topic/sdk/2/driver-connect to main April 11, 2024 15:49
bindings/python/src/connection.rs Outdated Show resolved Hide resolved
bindings/python/src/execution.rs Outdated Show resolved Hide resolved
@tychoish tychoish changed the base branch from main to tycho/topic/sdk/8/operation-interface April 12, 2024 17:30
Base automatically changed from tycho/topic/sdk/8/operation-interface to main April 15, 2024 21:52
@tychoish tychoish enabled auto-merge (squash) April 18, 2024 13:54
@tychoish tychoish merged commit 5107dd0 into main Apr 18, 2024
26 checks passed
@tychoish tychoish deleted the tycho/topic/sdk/4/python-integration branch April 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants