Refactor handleSaveEvent to use onWillSave async #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavin001
previously requested changes
Nov 20, 2017
|
Pushed update to 1.21.0 in package.json |
|
Awesome work! Beautify on save works great now! |
Glavin001
added a commit
that referenced
this pull request
Nov 22, 2017
This was referenced Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Refactors the
handleSaveEventfunction inbeautify.coffeeto make use ofonWillSavenow allowing async operations. It no longer waits for a save to complete before beautifying and then saving again, instead beautifies when the user invokes a save and afterwards the buffer saves....
Does this close any currently open issues?
#1895
...
Any other comments?
Would like some help testing this before it's considered for merging.
...
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docsCHANGELOG.mdunder "Next" section