Add Vue support to ESLint Fixer beautifier #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavin001
requested review from
Glavin001 and
stevenzeck
and removed request for
Glavin001
Glavin001
requested changes
Feb 6, 2018
Glavin001
added
add-language
waiting-for-user-information
enhancement
and removed
add-language
waiting-for-user-information
labels
|
I guess the beautify-languages-spec tests to 'examples/' directory only use default Currently, atom-beautify has two beautifier for Vue: "Vue Beautifier" and "ESLint Fixer". I tried to set default_beautifier to "ESLint Fixer" by .jsbeautifyrc, but it's not respected ( #1570 ) Do you have any other way to run the test using non default "ESLint Fixer" beautifier ? |
Glavin001
requested changes
Mar 2, 2018
| @@ -1,6 +1,7 @@ | |||
| # Next | |||
| - Fix [#1862](https://github.com/Glavin001/atom-beautify/issues/1862) Add support for ocp-indent as an executable | |||
| - See [#601](https://github.com/Glavin001/atom-beautify/issues/1862) Add support for tsx files | |||
| - See [#2026](https://github.com/Glavin001/atom-beautify/issues/2026) Add Vue support to ESLint Fixer beautifier | |||
There was a problem hiding this comment.
I think it's important to add a note here about requiring https://github.com/vuejs/eslint-plugin-vue for using ESLint Fixer on Vue files.
|
Published to v0.32.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
just add an Eslint Fixer beautifier option to support Vue language.
...
Does this close any currently open issues?
#2026
...
Any other comments?
Eslint can not only support *.js files but also *.vue files using plugins such as eslint-plugin-vue.
The users can use Eslint Fixer beautifier for vue by setting eslint can handle vue files.
...
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docsCHANGELOG.mdunder "Next" section