-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vue support to ESLint Fixer beautifier #2033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add examples for testing to examples/
directory.
I guess the beautify-languages-spec tests to 'examples/' directory only use default Currently, atom-beautify has two beautifier for Vue: "Vue Beautifier" and "ESLint Fixer". I tried to set default_beautifier to "ESLint Fixer" by .jsbeautifyrc, but it's not respected ( #1570 ) Do you have any other way to run the test using non default "ESLint Fixer" beautifier ? |
@@ -1,6 +1,7 @@ | |||
# Next | |||
- Fix [#1862](https://github.com/Glavin001/atom-beautify/issues/1862) Add support for ocp-indent as an executable | |||
- See [#601](https://github.com/Glavin001/atom-beautify/issues/1862) Add support for tsx files | |||
- See [#2026](https://github.com/Glavin001/atom-beautify/issues/2026) Add Vue support to ESLint Fixer beautifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to add a note here about requiring https://github.com/vuejs/eslint-plugin-vue for using ESLint Fixer on Vue files.
Published to v0.32.0 |
What does this implement/fix? Explain your changes.
just add an Eslint Fixer beautifier option to support Vue language.
...
Does this close any currently open issues?
#2026
...
Any other comments?
Eslint can not only support *.js files but also *.vue files using plugins such as eslint-plugin-vue.
The users can use Eslint Fixer beautifier for vue by setting eslint can handle vue files.
...
Checklist
Check all those that are applicable and complete.
master
branchnpm run docs
CHANGELOG.md
under "Next" section