Add JSCS Fixer #412
Merged
Add JSCS Fixer #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cannot be configured via the settings UI yet. - Only fixes files, that have a .jscsrc file in one of their parent folders (up to the project root folder in Atom).
|
Looks good. Please merge the latest upstream changes that fixes the CI errors and then this PR should pass all of the tests and be ready for merging. Thanks! |
Conflicts: package.json
jscs is only required, when actually used now.
|
Changes are merged now. The AppVeyor failure isn't related to the pull request (apparently Atom installation failed). |
|
Fixed now. |
|
Looks good! Thank you! |
|
Published to v0.28.7 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286.
Just a minimal implementation. Could still be improved:
folders (up to the project root folder in Atom).