Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add build target for protonfixes #119

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

R1kaB3rN
Copy link

@R1kaB3rN R1kaB3rN commented Aug 17, 2024

Depends on Open-Wine-Components/umu-protonfixes#100 being merged, which adds an initial build system for protonfixes to build current and future packages from source.

protonfixes currently commits the binaries for cabextract, libmspack.so, and xrandr to the repository which are needed for winetricks and some protonfixes functionality to work. While this works, it isn't guaranteed to be reliable nor sustainable if we decide to commit more binaries to that repo for fixes. Instead of committing those files to the repo, we should prefer to build them from source within the Steam Runtime container to guarantee the reliability of those files between major SLRs versions, and to provide users some transparency by specifying those files' source repository.

TODO:

  • Test build

@R1kaB3rN R1kaB3rN marked this pull request as ready for review August 31, 2024 03:31
@R1kaB3rN
Copy link
Author

The protonfixes target builds fine, but I'm running into gstreamer-related build errors when running make:

299:make: *** [../../Makefile.in:207: /home/foo/OSS/proton-ge-custom/build/builddir/.gst_base-configure64] Error 1
302:make: *** [../../Makefile.in:206: /home/foo/OSS/proton-ge-custom/build/builddir/.gst_base-configure32] Error 1

Log: https://gist.github.com/R1kaB3rN/f2913ebb9e6bf92bb21131b5490315f0

@R1kaB3rN
Copy link
Author

I don't think my changes are the cause of them, as nothing in the above log file indicates it's the protonfixes target and the protonfixes directory gets put in dist as expected.

Running ls dist inside proton-ge-custom/build/builddir:

compatibilitytool.vdf  files    LICENSE.OFL  proton                    protonfixes       user_settings.sample.py
filelock.py            LICENSE  PATENTS.AV1  proton_3.7_tracked_files  toolmanifest.vdf

Running ls dist/protonfixes:

cabextract  download.py       gamefixes-battlenet  gamefixes-humble   gamefixes-umu           libmspack.so.0      steamhelper.py  xrandr
checks.py   engine.py         gamefixes-ea         gamefixes-itchio   gamefixes-zoomplatform  libmspack.so.0.1.0  util.py
config.py   fix.py            gamefixes-egs        gamefixes-steam    __init__.py             logger.py           verbs
debug.py    gamefixes-amazon  gamefixes-gog        gamefixes-ubisoft  libmspack.so            protonfixes         winetricks

@R1kaB3rN
Copy link
Author

Output of gstreamer's meson-log.txt:

Build started at 2024-08-31T05:53:52.964415
Main binary: /usr/bin/python3
Build Options: -Dauto_features=disabled -Dintrospection=disabled -Dgobject-cast-checks=disabled -Dglib-asserts=disabled -Dglib-checks=disabled -Dnls=disabled -Dexamples=disabled -Dtests=disabled -Ddoc=disabled -Dadder=enabled -Dapp=enabled -Daudioconvert=enabled -Daudioresample=enabled -Dogg=enabled -Dopus=enabled -Dpbtypes=enabled -Dplayback=enabled -Dtheora=enabled -Dtypefind=enabled -Dvideoconvertscale=enabled -Dvorbis=enabled -Drawparse=enabled -Dorc=enabled -Dx11=enabled -Dgl=enabled -Dgl-graphene=enabled -Dgl_winsys=surfaceless,x11,wayland,egl -Dgl_platform=glx,egl -Dprefix=/home/foo/OSS/proton-ge-custom/build/builddir/dst-gst_base64 -Dlibdir=lib64 -Dbuildtype=plain -Dstrip=True -Dwrap_mode=nodownload
Python system: Linux
The Meson build system
Version: 1.0.1
Source dir: /home/foo/OSS/proton-ge-custom/build/builddir/src-gst_base
Build dir: /home/foo/OSS/proton-ge-custom/build/builddir/obj-gst_base64
Build type: native build

src-gst_base/meson.build:1:0: ERROR: Options "surfaceless" are not in allowed choices: "x11, wayland, win32, winrt, cocoa, dispmanx, egl, viv-fb, gbm, android, auto"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants