Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image improvements #160

Merged
merged 2 commits into from
Nov 3, 2019
Merged

Docker image improvements #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5c254
Added .dockerignore
obilodeau Oct 31, 2019
8dd6530
doc: better docker run instructions (port and volume relative to $PWD)
obilodeau Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
pyrdp_output/
venv*/
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ docker build -t pyrdp .
Afterwards, you can execute the following command to run the container:

```
docker run -it pyrdp pyrdp-mitm.py 192.168.1.10
docker run -it -p 3389:3389 pyrdp pyrdp-mitm.py 192.168.1.10
```

For more information about the various commands and arguments, please refer to these sections:
Expand All @@ -176,7 +176,7 @@ For more information about the various commands and arguments, please refer to t
To store the PyRDP output permanently (logs, files, etc.), add the -v option to the previous command. For example:

```
docker run -v /home/myname/pyrdp_output:/home/pyrdp/pyrdp_output pyrdp pyrdp-mitm.py 192.168.1.10
docker run -v $PWD/pyrdp_output:/home/pyrdp/pyrdp_output -p 3389:3389 pyrdp pyrdp-mitm.py 192.168.1.10
```

Make sure that your destination directory is owned by a user with a UID of 1000, otherwise you will get a permission denied error.
Expand Down