-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added --no-downgrade
mode.
#189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Didn't test but if there's a problem we can address it quickly post-merge.
@@ -306,6 +306,30 @@ After 5 seconds, input / output is restored back to normal. | |||
#### Other MITM arguments | |||
Run `pyrdp-mitm.py --help` for a full list of arguments. | |||
|
|||
##### `--no-downgrade` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this new section the ToC will need to be regenerated. They used an online tool to do so. It kind of sucks that this is a manual step to be honest. Migrating this file to AsciiDoc would eliminate that problem. That said, just updating the ToC would be fine for now.
Co-Authored-By: Olivier Bilodeau <obilodeau@gosecure.net>
This is a rework of the
--gdi-passthrough
branch that covers a broader set of passthrough options.After some internal discussion, a mode that avoids fingerprinting by not downgrading any of the connection features makes more sense than per-extension support switches, so I renamed the switch to
--no-downgrade
and added some documentation to explain its current state, what it can and cannot do, and its impacts on the PyRDP player.