Add support for XR_FB_composition_layer_secure_content #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
requested changes
Apr 5, 2024
common/src/main/cpp/extensions/openxr_fb_composition_layer_secure_content_extension_wrapper.cpp
Show resolved
Hide resolved
dsnopek
force-pushed
the
xr-fb-composition-layer-secure-content
branch
from
006982e to
ca0d89d
Compare
m4gr3d
requested changes
Apr 5, 2024
common/src/main/cpp/extensions/openxr_fb_composition_layer_secure_content_extension_wrapper.cpp
Show resolved
Hide resolved
common/src/main/cpp/extensions/openxr_fb_composition_layer_secure_content_extension_wrapper.cpp
Show resolved
Hide resolved
common/src/main/cpp/extensions/openxr_fb_composition_layer_secure_content_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
common/src/main/cpp/extensions/openxr_fb_composition_layer_secure_content_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
...c/main/cpp/include/extensions/openxr_fb_composition_layer_secure_content_extension_wrapper.h
Outdated
Show resolved
Hide resolved
dsnopek
force-pushed
the
xr-fb-composition-layer-secure-content
branch
from
ca0d89d to
0561c9b
Compare
m4gr3d
approved these changes
Apr 5, 2024
|
The Godot PR was merged, so taking this out of draft |
|
@dsnopek Can you rebase this PR for merging. |
dsnopek
force-pushed
the
xr-fb-composition-layer-secure-content
branch
from
0561c9b to
1d8fdeb
Compare
|
Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on PR godotengine/godot#90237
It adds a new "External Output" property to
OpenXRCompositionLayernodes, which can be used to set the flags used by XR_FB_composition_layer_secure_content to configure the given composition layer:I've tested this on the Meta Quest 3 and it works!
When casting to the web, setting the composition layer to "Replace" will display it blacked out in the cast, and setting to "Exclude" will remove it from the cast entirely. As expected, the setting has no effect in the headset.
Marking as draft until the Godot PR is merged.