[gRPCServerTest] gRPS server implemented #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshaman
approved these changes
Nov 14, 2022
| goodTemplate: []byte(`<html><body><h1 style="color:red;">Test html color<h1> | ||
| <p>{{.CourseName}}</p><p>{{.CourseType}}</p><p>{{.CourseHours}}</p><p>{{.CourseDate}}</p> | ||
| <p>{{.CourseMentors}}</p><p>{{.StudentFirstname}}</p><p>{{.StudentLastname}}</p> | ||
| </body></html>`), | ||
| failTemplate: []byte(`<html><body><h1 style="color:red;">Test html color<h1> | ||
| <p>{{.CourseName_Fail}}</p></body></html>`), | ||
| expected: []byte(`<html><body><h1 style="color:red;">Test html color<h1> | ||
| expectedCert: []byte(`<html><body><h1 style="color:red;">Test html color<h1> |
There was a problem hiding this comment.
Что-то не обратил внимания раньше. Тут по-хорошему должен быть failObject
There was a problem hiding this comment.
тут не понял. Почему должен failObject? Наоборот expectedCert это образец сертификата который должен сгенерироваться.
| @@ -52,7 +54,36 @@ func TestGenerateCertificate(t *testing.T) { | |||
| t.Error(err) | |||
| } | |||
|
|
|||
| if !reflect.DeepEqual(gotCertif, testData.expected) { | |||
| if !reflect.DeepEqual(gotCertif, testData.expectedCert) { | |||
There was a problem hiding this comment.
Опять же - лучше использовать какой-либо testify. Но это нужно было сделать раньше, сейчас можно отдельную таску.
There was a problem hiding this comment.
переделать все тесты под testify?
|
|
||
| func TestGenerateID(t *testing.T) { | ||
| generator := testData.certGenerator | ||
| _, err := generator.GenerateCertHTML(testData.goodTemplate) |
There was a problem hiding this comment.
мы не должны проверять работу генератора сертификата в тесте генератора ID
| @@ -4,7 +4,7 @@ import ( | |||
| "gus_certificates/utils/storage/local" | |||
| ) | |||
|
|
|||
| type storage interface { | |||
| type Storage interface { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS-15
What:
Реализована работа gRPC сервера.
Why:
Для получения и отправки запросов RPC.
How:
Добавлена инструкция по запуску сервера в файл README.md
Добавлен файл для генерации вспомогательных gRPC файлов protoc_options_generate.txt
Добавлен cmd/rpc/main.go для запуска RPC сервера.
Добавлена реализация функций сервера в файл app/server/server.go
В генератор сертификатов app/certgenerator/certgenerator.go добавлено 2 метода:
GenerateID - генерация ID/имени сертификата.
ValidateData - валидация входных данных по студенту и курсу.
Обновлены тесты.