Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FV Android: camera permissions + start session #3

Merged
merged 9 commits into from
Jan 5, 2021
Merged

FV Android: camera permissions + start session #3

merged 9 commits into from
Jan 5, 2021

Conversation

mauriguz
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

About # (link your issue here)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

serdiukov-o-nordwhale
serdiukov-o-nordwhale suggested changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@serdiukov-o-nordwhale serdiukov-o-nordwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you're already passing current activity to the EnrollmentProcessor, you could move everything inside it

@mauriguz mauriguz changed the title Handle camera permissions FV Android: camera permissions + start session Dec 31, 2020
serdiukov-o-nordwhale
serdiukov-o-nordwhale reviewed Jan 5, 2021
View reviewed changes
android/src/main/java/org/gooddollar/FaceTecModule.java Outdated
@@ -27,7 +27,7 @@
import com.facetec.sdk.FaceTecSessionStatus;
import com.facetec.sdk.FaceTecSDKStatus;

public class FaceTecModule extends ReactContextBaseJavaModule {
public class FaceTecModule extends ReactContextBaseJavaModule implements PermissionListener {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class FaceTecModule extends ReactContextBaseJavaModule implements PermissionListener {
public class FaceTecModule extends ReactContextBaseJavaModule {

@serdiukov-o-nordwhale serdiukov-o-nordwhale merged commit a1dfca4 into master Jan 5, 2021
@serdiukov-o-nordwhale serdiukov-o-nordwhale deleted the camera-permission branch January 5, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serdiukov-o-nordwhale serdiukov-o-nordwhale serdiukov-o-nordwhale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauriguz @serdiukov-o-nordwhale