fix: set browser preferences correctly

GoogleChrome · Jul 18, 2023 · cdc8cb9 · cdc8cb9
1 parent dacd357
commit cdc8cb9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/chrome-launcher.ts b/src/chrome-launcher.ts
@@ -230,7 +230,12 @@ class Launcher {
       return;
     }
 
-    const preferenceFile = `${this.userDataDir}/Preferences`;
+    const profileDir = `${this.userDataDir}/Default`;
+    if (!this.fs.existsSync(profileDir)) {
+      this.fs.mkdirSync(profileDir, {recursive: true});
+    }
+
+    const preferenceFile = `${profileDir}/Preferences`;
     try {
       if (this.fs.existsSync(preferenceFile)) {
         // overwrite existing file

diff --git a/test/chrome-launcher-test.ts b/test/chrome-launcher-test.ts
@@ -74,7 +74,8 @@ describe('Launcher', () => {
     const existStub = stub().returns(true)
     const readFileStub = stub().returns(JSON.stringify({ some: 'prefs' }))
     const writeFileStub = stub()
-    const fs = {...fsMock, rmdirSync: spy(), readFileSync: readFileStub, writeFileSync: writeFileStub, existsSync: existStub };
+    const mkdirStub = stub()
+    const fs = {...fsMock, rmdir: spy(), readFileSync: readFileStub, writeFileSync: writeFileStub, existsSync: existStub, mkdirSync: mkdirStub };
     const chromeInstance =
         new Launcher({prefs: {'download.default_directory': '/some/dir'}}, {fs: fs as any});
 
@@ -89,7 +90,8 @@ describe('Launcher', () => {
     const existStub = stub().returns(false)
     const readFileStub = stub().returns(Buffer.from(JSON.stringify({ some: 'prefs' })))
     const writeFileStub = stub()
-    const fs = {...fsMock, rmdirSync: spy(), readFileSync: readFileStub, writeFileSync: writeFileStub, existsSync: existStub };
+    const mkdirStub = stub()
+    const fs = {...fsMock, rmdir: spy(), readFileSync: readFileStub, writeFileSync: writeFileStub, existsSync: existStub, mkdirSync: mkdirStub };
     const chromeInstance =
         new Launcher({prefs: {'download.default_directory': '/some/dir'}}, {fs: fs as any});