Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump to is-wsl@2.2.0 #187

Merged
merged 3 commits into from
May 7, 2020
Merged

deps: bump to is-wsl@2.2.0 #187

merged 3 commits into from
May 7, 2020

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Feb 3, 2020

edit: ignore everything after the hr

just bringing over two small fixes. one for linux and one for docker. https://github.com/sindresorhus/is-wsl/releases


wsl2 happened and is-wsl added support: sindresorhus/is-wsl#3

ref https://github.com/GoogleChrome/lighthouse/issues/10288

@patrickhulce
Copy link
Collaborator

We should already have WSL 2 support @paulirish

https://github.com/sindresorhus/is-wsl/releases/tag/v2.1.0

2.1.1 was just a linux bug fix for returning false

I think something else might be going on here...

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still seems fine to bump though :)

LGTM

@paulirish
Copy link
Member Author

ah it was done back here: #152

okay yeah definitely something else going on.

@paulirish paulirish changed the title deps: is-wsl@2.1.1 for wsl support deps: bump to is-wsl@2.2.0 May 7, 2020
@paulirish paulirish merged commit 7c1ea54 into master May 7, 2020
@paulirish paulirish deleted the wsl2 branch May 7, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants