add support for connectionPollInterval and maxConnectionRetries
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
approved these changes
Sep 6, 2017
| @@ -270,7 +275,7 @@ export class Launcher { | |||
| resolve(); | |||
| }) | |||
| .catch(err => { | |||
| if (retries > 10) { | |||
| if (retries > launcher.maxConnectionRetries) { | |||
There was a problem hiding this comment.
Hi and thanks for the PR. I think this is a great addition!
There was a problem hiding this comment.
Hi Sam, thanks!
paulirish
approved these changes
Sep 8, 2017
This was referenced Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a copy of GoogleChrome/lighthouse#3129 and addresses #12
Also this may fix GoogleChrome/lighthouse#2616, because the main goal is to avoid
ECONNREFUSED. In my experiments, this issue was related with not enough time in 100% cases, just increase from 5s to 25s fixedECONNREFUSED.