move to minimum node 12; remove rimraf #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Apr 14, 2021
| @@ -1,5 +1,4 @@ | |||
| # Chrome Launcher [](https://travis-ci.org/GoogleChrome/chrome-launcher) [](https://ci.appveyor.com/project/paulirish/chrome-launcher/branch/master) [](https://npmjs.org/package/chrome-launcher) | |||
|
|
|||
| # Chrome Launcher [](https://github.com/GoogleChrome/chrome-launcher/actions) [](https://npmjs.org/package/chrome-launcher) | |||
There was a problem hiding this comment.
drive-by badge fix for the migration to github actions
| @@ -2,7 +2,7 @@ | |||
| "compilerOptions": { | |||
| "module": "commonjs", | |||
| "outDir": "dist", | |||
| "target": "es2016", | |||
| "target": "es2019", | |||
There was a problem hiding this comment.
as officially suggested here. Savings in dist/ are pretty small (about 3KiB), but it's nice that async/await is no longer transpiled, yielding a pretty big readability improvement in chrome-launcher.js if you aren't using source maps.
paulirish
approved these changes
Apr 15, 2021
|
In node v14.14+ a deprecation warning is now always given: https://nodejs.org/api/deprecations.html#DEP0147 In v16+ node ignores the recursive flag. I can submit a PR for a feature check if fs.rm is available to use that instead of fs.rmdir. let rm = fs.rm || fs.rmdir;
rm(path, { recursive: true });That way we can stay backwards compatible with v12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 10 will be EoL on April 30, just about the time we might possibly do another release of chrome-launcher, so seems ok to do now.
We should bump the next release to
0.14.0, though.With node 12 comes
fs.rmdir(path, {recursive: true}), so we don't need rimraf anymore.