-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow user to set browser preferences #247
feat: Allow user to set browser preferences #247
Conversation
5a6d2c7
to
928f972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @christian-bromann !
9b29a4e
to
1a6fea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when tests pass, thanks! :)
1a6fea4
to
e8d6adf
Compare
e8d6adf
to
1c28280
Compare
Is there anything else I can do? |
you just did it (a reminder when the tests pass 😉 ) thanks @christian-bromann! |
Hi guys. @patrickhulce @paulirish sorry for disturbing you, do you guys know when we can expect this feature to be released? |
thank you :) @patrickhulce |
@christian-bromann this preference file thing.. works, right? |
@paulirish I tried to verify and it seems to not work anymore. Launching Chrome as following:
While having a pref file written at {
"devtools.preferences.currentDockState": "\"bottom\"",
"devtools.preferences.splitLocation": "\"50%\"",
"devtools.preferences.panel-selectedTab": "\"console\""
} Does not to have any effect anymore. |
@christian-bromann Try setting it to this file: |
@christian-bromann yeah i think you're missing the |
Thanks @paulirish , I will look into raising a PR with a fix for this. |
implements: #213
In WebdriverIO we offer to run automated browser tests using WebDriver or CDP (via Puppeteer). When we start a Puppeteer browser we use this package as it gives us more options to set the browser session. However it is not possible to set a custom set of browser preferences, e.g. to define the default download directory. This patch adds this capability to the package. To create feature parity given that Chromedriver allows this, it would be great if we could add this.