Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Update Lighthouse is-crawlable audit doc #5111

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

adamraine
Copy link
Member

Closes GoogleChrome/lighthouse#5329

Lighthouse will now look for crawler-specific directives and emit a warning if they are found: GoogleChrome/lighthouse#14550

cc @connorjclark

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for developer-chrome-com ready!

Name Link
🔨 Latest commit ac500a0
🔍 Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/63dac356bc73eb0008e355da
😎 Deploy Preview https://deploy-preview-5111--developer-chrome-com.netlify.app/en/docs/lighthouse/seo/is-crawlable
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

```

Lighthouse doesn't check for crawler-specific directives like this, but they can
still make your page harder to discover, so use them with caution.
Lighthouse doesn't fail the audit for crawler-specific directives like this, but they can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudl we qualify this as "as of 10.0"? Must account for chrome stable running older LH longer than other channels; and to a lesser extent, historical LH versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a 10.0 disclaimer for something as minor as this

Copy link
Contributor

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but merging should hold for our release.

Copy link
Member

@malchata malchata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brendankenny brendankenny merged commit 3082bea into GoogleChrome:main Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is-crawlable fails when robots.txt specifies user-agents
4 participants