Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add LCP phase breakdown to the Lighthouse docs #6125

Merged
merged 3 commits into from
May 3, 2023

Conversation

adamraine
Copy link
Member

@chrome-devrel-infra
Copy link

chrome-devrel-infra bot commented Apr 26, 2023

@tunetheweb
Copy link
Member

This page says LCP landed in Chrome 77, but doesn't say when this breakdown phase landed. There might be an expectation it's there from Chrome 77 too.

Suggestions:

  • Remove references to Chrome 77 (it's so long ago who cares!)
  • Consider adding a "From Lighthosue 10.2, Lighthouse will display the LCP element along with the phase breakdown...". That will get old too so maybe not needed (especially when references to Chrome 77 are gone)? What do you usually do here?

@adamraine
Copy link
Member Author

adamraine commented Apr 27, 2023

Remove references to Chrome 77 (it's so long ago who cares!)

This works for me.

Consider adding a "From Lighthosue 10.2, Lighthouse will display the LCP element along with the phase breakdown...". That will get old too so maybe not needed (especially when references to Chrome 77 are gone)? What do you usually do here?

I'm generally opposed to calling out when a specific feature was added unless it's super important or a breaking change. This is just adding extra diagnostic information to an existing audit.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit 7c9568c into GoogleChrome:main May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants