-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stack pack for Wix #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug through some of the docs linked here, and there is good advice. However most of these strings either don't provide any actionable advice for the user, or provide some general advice that Lighthouse already covers.
@adamraine thanks for the review, I removed offscreen-images and font-display which weren't actionable for now, and modified server-response-time and modern-image-formats according to your suggestions. The reason to ask users to re-run is that the slow server response time may appear once, and disappear after running the test again, but I understand why not to encourage users to do this, they will probably find that out themselves. I also fixed the link for the unused JS text - but in general one of the main problems we are seeing users get wrong is adding custom third party code to their HTML, which is either render blocking or unused. We explain this here https://support.wix.com/en/article/site-performance-using-third-party-code-on-your-site and would love to explain to users what they can actually do, using our tools, using built-in marketing integrations, or alternatively place the code at the end of the body or at least defer it. Another distinction we want to explain is that code from static.parastorage.com is Wix code (though its from a "third party domain" and not the user domain) - which they cannot change themselves, as explained here - https://support.wix.com/en/article/site-performance-removing-unused-javascript It's holidays here, but after that we will try to propose text for these that is a bit more actionable and explains what Wix users can do about these things, so we do end up with a few meaningful tips in the first version. Ideally we want to enhance these, and add product features such as customizing font-display |
Updated proposal
fix syntax
@adamraine I updated the proposed text, could you please have an additional look? |
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
Thanks, good to know. We do have translations of some of these articles, would it be possible to provide a list of links for available languages? For example https://support.wix.com/en/article/site-performance-optimizing-your-media is also available in 11 other languages: https://support.wix.com/es/article/rendimiento-del-sitio-optimizar-los-archivos-multimedia (Press the small globe on the header to see languages) |
We cannot provide multiple versions of links in these strings. The wix docs would need to automatically detect the user locale and serve the correct language. We would likely also want to have 100% overlap between supported locales. |
@alonkochba tests are failing, can you add a wix item to https://github.com/GoogleChrome/lighthouse-stack-packs/blob/master/index.js |
Sure, added, thanks! |
I don't think so unfortunately. |
No description provided.