core(canonical): proper explanation for url misuse (#12676)

GoogleChrome · Jul 8, 2021 · 000da66 · 000da66
1 parent 08425f0
commit 000da66
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lighthouse-core/audits/seo/canonical.js b/lighthouse-core/audits/seo/canonical.js
@@ -32,7 +32,7 @@ const UIStrings = {
    * @description Explanatory message stating that there was a failure in an audit caused by a URL being relative instead of absolute.
    * @example {https://example.com/} url
    * */
-  explanationRelative: 'Relative URL ({url})',
+  explanationRelative: 'Is not an absolute URL ({url})',
   /**
    * @description Explanatory message stating that there was a failure in an audit caused by a URL pointing to a different hreflang than the current context.'hreflang' is an HTML attribute and should not be translated.
    * @example {https://example.com/} url

diff --git a/lighthouse-core/lib/i18n/locales/en-US.json b/lighthouse-core/lib/i18n/locales/en-US.json
diff --git a/lighthouse-core/lib/i18n/locales/en-XL.json b/lighthouse-core/lib/i18n/locales/en-XL.json
diff --git a/lighthouse-core/test/audits/seo/canonical-test.js b/lighthouse-core/test/audits/seo/canonical-test.js
@@ -101,7 +101,7 @@ describe('SEO: Document has valid canonical link', () => {
     return CanonicalAudit.audit(artifacts, context).then(auditResult => {
       const {score, explanation} = auditResult;
       assert.equal(score, 0);
-      expect(explanation).toBeDisplayString('Relative URL (/)');
+      expect(explanation).toBeDisplayString('Is not an absolute URL (/)');
     });
   });