core(no-unload-listeners): move to best practices

GoogleChrome · Jan 11, 2023 · 029b7ad · 029b7ad
1 parent 40e8195
commit 029b7ad
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 19 deletions.
diff --git a/core/config/default-config.js b/core/config/default-config.js
@@ -517,7 +517,6 @@ const defaultConfig = {
         {id: 'non-composited-animations', weight: 0},
         {id: 'unsized-images', weight: 0},
         {id: 'viewport', weight: 0},
-        {id: 'no-unload-listeners', weight: 0},
         {id: 'uses-responsive-images-snapshot', weight: 0},
         {id: 'work-during-interaction', weight: 0},
         {id: 'bf-cache', weight: 0},
@@ -623,6 +622,7 @@ const defaultConfig = {
         {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'},
         {id: 'charset', weight: 1, group: 'best-practices-browser-compat'},
         // General Group
+        {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'},
         {id: 'js-libraries', weight: 0, group: 'best-practices-general'},
         {id: 'deprecations', weight: 1, group: 'best-practices-general'},
         {id: 'errors-in-console', weight: 1, group: 'best-practices-general'},

diff --git a/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json b/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json
@@ -3998,10 +3998,6 @@
                 "id": "viewport",
                 "weight": 0
               },
-              {
-                "id": "no-unload-listeners",
-                "weight": 0
-              },
               {
                 "id": "bf-cache",
                 "weight": 0
@@ -4396,6 +4392,11 @@
                 "weight": 1,
                 "group": "best-practices-browser-compat"
               },
+              {
+                "id": "no-unload-listeners",
+                "weight": 1,
+                "group": "best-practices-general"
+              },
               {
                 "id": "js-libraries",
                 "weight": 0,
@@ -9338,10 +9339,6 @@
                 "id": "unsized-images",
                 "weight": 0
               },
-              {
-                "id": "no-unload-listeners",
-                "weight": 0
-              },
               {
                 "id": "work-during-interaction",
                 "weight": 0
@@ -9417,6 +9414,11 @@
                 "weight": 0,
                 "group": "best-practices-ux"
               },
+              {
+                "id": "no-unload-listeners",
+                "weight": 1,
+                "group": "best-practices-general"
+              },
               {
                 "id": "deprecations",
                 "weight": 1,
@@ -9439,7 +9441,7 @@
               }
             ],
             "id": "best-practices",
-            "score": 0.83
+            "score": 0.86
           }
         },
         "categoryGroups": {
@@ -18210,10 +18212,6 @@
                 "id": "viewport",
                 "weight": 0
               },
-              {
-                "id": "no-unload-listeners",
-                "weight": 0
-              },
               {
                 "id": "bf-cache",
                 "weight": 0
@@ -18608,6 +18606,11 @@
                 "weight": 1,
                 "group": "best-practices-browser-compat"
               },
+              {
+                "id": "no-unload-listeners",
+                "weight": 1,
+                "group": "best-practices-general"
+              },
               {
                 "id": "js-libraries",
                 "weight": 0,

diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json
@@ -6291,10 +6291,6 @@
           "id": "viewport",
           "weight": 0
         },
-        {
-          "id": "no-unload-listeners",
-          "weight": 0
-        },
         {
           "id": "bf-cache",
           "weight": 0
@@ -6689,6 +6685,11 @@
           "weight": 1,
           "group": "best-practices-browser-compat"
         },
+        {
+          "id": "no-unload-listeners",
+          "weight": 1,
+          "group": "best-practices-general"
+        },
         {
           "id": "js-libraries",
           "weight": 0,
@@ -6716,7 +6717,7 @@
         }
       ],
       "id": "best-practices",
-      "score": 0.27
+      "score": 0.25
     },
     "seo": {
       "title": "SEO",