Skip to content

Commit

Permalink
comment out config changes until skipAudits landsa
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhulce committed Jun 16, 2017
1 parent 3f7351c commit 11a812b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
26 changes: 12 additions & 14 deletions lighthouse-core/config/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,14 @@ module.exports = {
'dobetterweb/websql',
]
},
{
passName: 'extrasPass',
useThrottling: false,
// Just wait for onload
networkQuietThresholdMs: 0,
gatherers: [
'styles',
'css-usage',
],
},
// {
// passName: 'extrasPass',
// useThrottling: false,
// gatherers: [
// 'styles',
// 'css-usage',
// ],
// },
{
passName: 'offlinePass',
useThrottling: false,
Expand Down Expand Up @@ -132,7 +130,7 @@ module.exports = {
'accessibility/video-caption',
'accessibility/video-description',
'byte-efficiency/total-byte-weight',
'byte-efficiency/unused-css-rules',
// 'byte-efficiency/unused-css-rules',
'byte-efficiency/offscreen-images',
'byte-efficiency/uses-webp-images',
'byte-efficiency/uses-optimized-images',
Expand All @@ -145,7 +143,7 @@ module.exports = {
'dobetterweb/link-blocking-first-paint',
'dobetterweb/no-document-write',
'dobetterweb/no-mutation-events',
'dobetterweb/no-old-flexbox',
// 'dobetterweb/no-old-flexbox',
'dobetterweb/no-websql',
'dobetterweb/notification-on-start',
'dobetterweb/password-inputs-can-be-pasted-into',
Expand Down Expand Up @@ -239,7 +237,7 @@ module.exports = {
{id: 'estimated-input-latency', weight: 1, group: 'perf-metric'},
{id: 'link-blocking-first-paint', weight: 0, group: 'perf-hint'},
{id: 'script-blocking-first-paint', weight: 0, group: 'perf-hint'},
{id: 'unused-css-rules', weight: 0, group: 'perf-hint'},
// {id: 'unused-css-rules', weight: 0, group: 'perf-hint'},
{id: 'uses-responsive-images', weight: 0, group: 'perf-hint'},
{id: 'offscreen-images', weight: 0, group: 'perf-hint'},
{id: 'uses-optimized-images', weight: 0, group: 'perf-hint'},
Expand Down Expand Up @@ -303,7 +301,7 @@ module.exports = {
{id: 'no-websql', weight: 1},
{id: 'is-on-https', weight: 1},
{id: 'uses-http2', weight: 1},
{id: 'no-old-flexbox', weight: 1},
// {id: 'no-old-flexbox', weight: 1},
{id: 'uses-passive-event-listeners', weight: 1},
{id: 'no-mutation-events', weight: 1},
{id: 'no-document-write', weight: 1},
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/test/config/config-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ describe('Config', () => {
settings: {
onlyCategories: ['performance'],
onlyAudits: ['is-on-https'],
skipAudits: ['unused-css-rules', 'no-old-flexbox'],
},
});

Expand Down

0 comments on commit 11a812b

Please sign in to comment.