tests(eslint): add import/order rule for core tests (#13955)

GoogleChrome · May 5, 2022 · 3159565 · 3159565
1 parent 54a1e04
commit 3159565
Show file tree

Hide file tree

Showing 302 changed files with 623 additions and 479 deletions.
diff --git a/lighthouse-core/test/.eslintrc.cjs b/lighthouse-core/test/.eslintrc.cjs
@@ -0,0 +1,28 @@
+/**
+ * @license Copyright 2022 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+module.exports = {
+  rules: {
+    // TODO(esmodules): move to root eslint when all code is ESM
+    // or when this is resolved: https://github.com/import-js/eslint-plugin-import/issues/2214
+    'import/order': [2, {
+      'groups': [
+        'builtin',
+        'external',
+        ['sibling', 'parent'],
+        'index',
+        'object',
+        'type',
+      ],
+      'newlines-between': 'always',
+    }],
+    'import/group-exports': 2,
+    'import/exports-last': 2,
+  },
+  parserOptions: {
+    sourceType: 'module',
+  },
+};
diff --git a/lighthouse-core/test/audits/accessibility/aria-allowed-attr-test.js b/lighthouse-core/test/audits/accessibility/aria-allowed-attr-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-allowed-attr.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-allowed-attr.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-allowed-attr audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/aria-required-attr-test.js b/lighthouse-core/test/audits/accessibility/aria-required-attr-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-required-attr.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-required-attr.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-required-attr audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/aria-required-children-test.js b/lighthouse-core/test/audits/accessibility/aria-required-children-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-required-children.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-required-children.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-required-children audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/aria-required-parent-test.js b/lighthouse-core/test/audits/accessibility/aria-required-parent-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-required-parent.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-required-parent.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-required-parent audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/aria-roles-test.js b/lighthouse-core/test/audits/accessibility/aria-roles-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-roles.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-roles.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-roles audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/aria-valid-attr-test.js b/lighthouse-core/test/audits/accessibility/aria-valid-attr-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-valid-attr.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-valid-attr.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-valid-attr audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/aria-valid-attr-value-test.js b/lighthouse-core/test/audits/accessibility/aria-valid-attr-value-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/aria-valid-attr-value.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/aria-valid-attr-value.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: aria-valid-attr-value audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/axe-audit-test.js b/lighthouse-core/test/audits/accessibility/axe-audit-test.js
@@ -3,11 +3,13 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import AxeAudit from '../../../audits/accessibility/axe-audit.js';
+
 import {strict as assert} from 'assert';
+
 import axeCore from 'axe-core';
+
+import AxeAudit from '../../../audits/accessibility/axe-audit.js';
 import Accesskeys from '../../../audits/accessibility/accesskeys.js';
 import format from '../../../../shared/localization/format.js';
 

diff --git a/lighthouse-core/test/audits/accessibility/button-name-test.js b/lighthouse-core/test/audits/accessibility/button-name-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/button-name.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/button-name.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: button-name audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/bypass-test.js b/lighthouse-core/test/audits/accessibility/bypass-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/bypass.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/bypass.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: bypass audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/color-contrast-test.js b/lighthouse-core/test/audits/accessibility/color-contrast-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/color-contrast.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/color-contrast.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: color-contrast audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/definition-list-test.js b/lighthouse-core/test/audits/accessibility/definition-list-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/definition-list.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/definition-list.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: definition-list audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/dlitem-test.js b/lighthouse-core/test/audits/accessibility/dlitem-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/dlitem.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/dlitem.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: dlitem audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/document-title-test.js b/lighthouse-core/test/audits/accessibility/document-title-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/document-title.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/document-title.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: document-title audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/frame-title-test.js b/lighthouse-core/test/audits/accessibility/frame-title-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/frame-title.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/frame-title.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: frame-title audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/html-has-lang-test.js b/lighthouse-core/test/audits/accessibility/html-has-lang-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/html-has-lang.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/html-has-lang.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: html-has-lang audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/html-lang-valid-test.js b/lighthouse-core/test/audits/accessibility/html-lang-valid-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/html-lang-valid.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/html-lang-valid.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: html-lang-valid audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/image-alt-test.js b/lighthouse-core/test/audits/accessibility/image-alt-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/image-alt.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/image-alt.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: image-alt audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/input-image-alt-test.js b/lighthouse-core/test/audits/accessibility/input-image-alt-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/input-image-alt.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/input-image-alt.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: input-image-alt audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/label-test.js b/lighthouse-core/test/audits/accessibility/label-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/label.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/label.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: label audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/link-name-test.js b/lighthouse-core/test/audits/accessibility/link-name-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/link-name.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/link-name.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: link-name audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/list-test.js b/lighthouse-core/test/audits/accessibility/list-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/list.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/list.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: list audit', () => {

diff --git a/lighthouse-core/test/audits/accessibility/listitem-test.js b/lighthouse-core/test/audits/accessibility/listitem-test.js
@@ -3,11 +3,12 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
-'use strict';
 
-import Audit from '../../../audits/accessibility/listitem.js';
+
 import {strict as assert} from 'assert';
 
+import Audit from '../../../audits/accessibility/listitem.js';
+
 /* eslint-env jest */
 
 describe('Accessibility: listitem audit', () => {