Skip to content

Commit

Permalink
core(unused-css): change title Defer -> Remove (#7235)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhulce authored and paulirish committed Feb 14, 2019
1 parent 4290080 commit 3df08f4
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions lighthouse-core/audits/byte-efficiency/unused-css-rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ const i18n = require('../../lib/i18n/i18n.js');

const UIStrings = {
/** Imperative title of a Lighthouse audit that tells the user to remove content from their CSS that isn’t needed immediately and instead load that content at a later time. This is displayed in a list of audit titles that Lighthouse generates. */
title: 'Defer unused CSS',
title: 'Remove unused CSS',
/** Description of a Lighthouse audit that tells the user *why* they should defer loading any content in CSS that isn’t needed at page load. This is displayed after a user expands the section to see more. No word length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Remove unused rules from stylesheets to reduce unnecessary ' +
'bytes consumed by network activity. ' +
description: 'Remove dead rules from stylesheets and defer the loading of CSS not used for ' +
'above-the-fold content to reduce unnecessary bytes consumed by network activity. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).',
};

Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/lib/i18n/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -504,11 +504,11 @@
"description": "Imperative title of a Lighthouse audit that tells the user to minify the page’s JS code to reduce file size. This is displayed in a list of audit titles that Lighthouse generates."
},
"lighthouse-core/audits/byte-efficiency/unused-css-rules.js | description": {
"message": "Remove unused rules from stylesheets to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).",
"message": "Remove dead rules from stylesheets and defer the loading of CSS not used for above-the-fold content to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).",
"description": "Description of a Lighthouse audit that tells the user *why* they should defer loading any content in CSS that isn’t needed at page load. This is displayed after a user expands the section to see more. No word length limits. 'Learn More' becomes link text to additional documentation."
},
"lighthouse-core/audits/byte-efficiency/unused-css-rules.js | title": {
"message": "Defer unused CSS",
"message": "Remove unused CSS",
"description": "Imperative title of a Lighthouse audit that tells the user to remove content from their CSS that isn’t needed immediately and instead load that content at a later time. This is displayed in a list of audit titles that Lighthouse generates."
},
"lighthouse-core/audits/byte-efficiency/unused-javascript.js | description": {
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -2410,8 +2410,8 @@
},
"unused-css-rules": {
"id": "unused-css-rules",
"title": "Defer unused CSS",
"description": "Remove unused rules from stylesheets to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).",
"title": "Remove unused CSS",
"description": "Remove dead rules from stylesheets and defer the loading of CSS not used for above-the-fold content to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).",
"score": 1,
"scoreDisplayMode": "numeric",
"rawValue": 0,
Expand Down
4 changes: 2 additions & 2 deletions proto/sample_v2_round_trip.json
Original file line number Diff line number Diff line change
Expand Up @@ -2533,7 +2533,7 @@
"warnings": []
},
"unused-css-rules": {
"description": "Remove unused rules from stylesheets to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).",
"description": "Remove dead rules from stylesheets and defer the loading of CSS not used for above-the-fold content to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).",
"details": {
"headings": [],
"items": [],
Expand All @@ -2544,7 +2544,7 @@
"id": "unused-css-rules",
"score": 1.0,
"scoreDisplayMode": "numeric",
"title": "Defer unused CSS"
"title": "Remove unused CSS"
},
"use-landmarks": {
"description": "Landmark elements (<main>, <nav>, etc.) are used to improve the keyboard navigation of the page for assistive technology. [Learn more](https://developers.google.com/web/fundamentals/accessibility/how-to-review#take_advantage_of_headings_and_landmarks).",
Expand Down

0 comments on commit 3df08f4

Please sign in to comment.