pr feedback

GoogleChrome · Jan 5, 2018 · 7aa5bc5 · 7aa5bc5
1 parent 3a47fef
commit 7aa5bc5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lighthouse-cli/cli-flags.js b/lighthouse-cli/cli-flags.js
@@ -67,7 +67,7 @@ function getFlags(manualArgv) {
         'disable-cpu-throttling': 'Disable CPU throttling',
         'disable-network-throttling': 'Disable network throttling',
         'gather-mode':
-            'Collect artifacts from a connected browser and save to disk. If audit-mode is not also enabled, the run quit early.',
+            'Collect artifacts from a connected browser and save to disk. If audit-mode is not also enabled, the run will quit early.',
         'audit-mode': 'Process saved artifacts from disk',
         'save-assets': 'Save the trace contents & screenshots to disk',
         'save-artifacts': 'Save all gathered artifacts to disk',

diff --git a/lighthouse-cli/run.js b/lighthouse-cli/run.js
@@ -108,11 +108,11 @@ function handleError(err) {
  * @return {!Promise<void>}
  */
 function saveResults(results, artifacts, flags) {
-  const shouldSaveResults = flags.auditMode || (flags.gatherMode == flags.auditMode);
+  const cwd = process.cwd();
   let promise = Promise.resolve();
-  if (!shouldSaveResults) return promise;
 
-  const cwd = process.cwd();
+  const shouldSaveResults = flags.auditMode || (flags.gatherMode === flags.auditMode);
+  if (!shouldSaveResults) return promise;
 
   // Use the output path as the prefix for all generated files.
   // If no output path is set, generate a file prefix using the URL and date.
@@ -162,7 +162,7 @@ function saveResults(results, artifacts, flags) {
 function runLighthouse(url, flags, config) {
   /** @type {!LH.LaunchedChrome} */
   let launchedChrome;
-  const shouldGather = flags.gatherMode || flags.gatherMode == flags.auditMode;
+  const shouldGather = flags.gatherMode || flags.gatherMode === flags.auditMode;
   /** @type {!Promise<!LH.Results|void>} */
   let promise = Promise.resolve();
   /** @type {!Promise<!LH.Results>|undefined} */