Merge branch 'main' into prioritize-lcp-rename

GoogleChrome · Feb 7, 2023 · 873b49f · 873b49f
2 parents 9bcac6f + 74ead2a
commit 873b49f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/cli/test/smokehouse/test-definitions/metrics-tricky-tti.js b/cli/test/smokehouse/test-definitions/metrics-tricky-tti.js
@@ -34,6 +34,8 @@ const expectations = {
     finalDisplayedUrl: 'http://localhost:10200/tricky-tti.html',
     audits: {
       'interactive': {
+        // https://bugs.chromium.org/p/chromium/issues/detail?id=1413830
+        _maxChromiumVersion: '111',
         // stalls for ~5 seconds, ~5 seconds out, so should be at least ~10s
         numericValue: '>9900',
       },

diff --git a/core/audits/valid-source-maps.js b/core/audits/valid-source-maps.js
@@ -7,6 +7,8 @@
 import {Audit} from './audit.js';
 import {EntityClassification} from '../computed/entity-classification.js';
 import * as i18n from '../lib/i18n/i18n.js';
+import {Util} from '../../shared/util.js';
+import UrlUtils from '../lib/url-utils.js';
 
 const UIStrings = {
   /** Title of a Lighthouse audit that provides detail on HTTP to HTTPS redirects. This descriptive title is shown to users when HTTP traffic is redirected to HTTPS. */
@@ -54,11 +56,13 @@ class ValidSourceMaps extends Audit {
    * @return {boolean}
    */
   static isLargeFirstPartyJS(script, classifiedEntities) {
-    if (!script.length) return false;
+    const url = script.url;
+    if (!script.length || !url) return false;
+    if (!UrlUtils.isValid(url)) return false;
+    if (!Util.createOrReturnURL(url).protocol.startsWith('http')) return false;
 
     const isLargeJS = script.length >= LARGE_JS_BYTE_THRESHOLD;
-    const isFirstPartyJS = script.url ? classifiedEntities.isFirstParty(script.url) : false;
-    return isLargeJS && isFirstPartyJS;
+    return classifiedEntities.isFirstParty(url) && isLargeJS;
   }
 
   /**