Skip to content

Commit

Permalink
tests(devtools): sync webtests (#12578)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored May 28, 2021
1 parent 0689e4e commit 9f58f30
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/devtools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
${{ env.BLINK_TOOLS_PATH }}
${{ github.workspace }}/lighthouse/.tmp/chromium-web-tests/content-shells
# The number is how many times this hash key was manually updated to break the cache.
key: ${{ runner.os }}-1-${{ hashFiles('third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/*.js', 'lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }}
key: ${{ runner.os }}-2-${{ hashFiles('third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/*.js', 'lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }}

- name: Use Node.js 12.x
uses: actions/setup-node@v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
TestRunner.addResult(`disableStorageReset: ${lhr.configSettings.disableStorageReset}`);
TestRunner.addResult(`throttlingMethod: ${lhr.configSettings.throttlingMethod}`);

const viewTraceButton = LighthouseTestRunner.getResultsElement().querySelector('.view-trace');
const viewTraceButton = LighthouseTestRunner.getResultsElement().querySelector('.lh-button--trace');
TestRunner.addResult(`\nView Trace Button Text: "${viewTraceButton.textContent}"`);
TestRunner.addResult(`View Trace Button Title: "${viewTraceButton.title}"`);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
const waitForShowView = new Promise(resolve => {
TestRunner.addSniffer(UI.ViewManager.prototype, 'showView', resolve);
});
const viewTraceButton = LighthouseTestRunner.getResultsElement().querySelector('.view-trace');
const viewTraceButton = LighthouseTestRunner.getResultsElement().querySelector('.lh-button--trace');
TestRunner.addResult(`\nView Trace Button Text: "${viewTraceButton.textContent}"`);
TestRunner.addResult(`View Trace Button Title: "${UI.Tooltip.getContent(viewTraceButton)}"`);
viewTraceButton.click();
Expand Down

0 comments on commit 9f58f30

Please sign in to comment.