core: remove tap-targets and show target-size in a11y (#15906)

GoogleChrome · Apr 1, 2024 · acfd1fb · acfd1fb
1 parent 3f4b61d
commit acfd1fb
Show file tree

Hide file tree

Showing 64 changed files with 49 additions and 2,819 deletions.
diff --git a/cli/test/fixtures/dobetterweb/dbw_tester.html b/cli/test/fixtures/dobetterweb/dbw_tester.html
@@ -242,16 +242,6 @@ <h2 id="toppy" style="background-image:url('');">Do better web tester page</h2>
 <!-- FAIL(efficient-animated-content): animated gif found -->
 <img src="lighthouse-rotating.gif" width="811" height="462">
 
-<!-- FAIL(tap-targets): buttons too close together -->
-<style>
-.small-button {
-  display: block;
-  width: 200px;
-}
-</style>
-<button class="small-button">Do something</button>
-<button class="small-button">Do something else</button>
-
 <!-- Some websites overwrite the original Error object. The captureJSCallUsage function
   relies on the native Error object and prepareStackTrace from V8. When overwriting the stack
   property the e.stack inside the gatherer won't be in the correct format

diff --git a/cli/test/fixtures/seo/seo-tap-targets.html b/cli/test/fixtures/seo/seo-tap-targets.html
diff --git a/cli/test/smokehouse/core-tests.js b/cli/test/smokehouse/core-tests.js
@@ -61,7 +61,6 @@ import screenshot from './test-definitions/screenshot.js';
 import seoFailing from './test-definitions/seo-failing.js';
 import seoPassing from './test-definitions/seo-passing.js';
 import seoStatus403 from './test-definitions/seo-status-403.js';
-import seoTapTargets from './test-definitions/seo-tap-targets.js';
 import serviceWorkerReloaded from './test-definitions/service-worker-reloaded.js';
 import shiftAttribution from './test-definitions/shift-attribution.js';
 import sourceMaps from './test-definitions/source-maps.js';
@@ -126,7 +125,6 @@ const smokeTests = [
   seoFailing,
   seoPassing,
   seoStatus403,
-  seoTapTargets,
   serviceWorkerReloaded,
   shiftAttribution,
   sourceMaps,

diff --git a/cli/test/smokehouse/test-definitions/dobetterweb.js b/cli/test/smokehouse/test-definitions/dobetterweb.js
@@ -442,15 +442,15 @@ const expectations = {
       },
       'dom-size': {
         score: 1,
-        numericValue: 154,
+        numericValue: 151,
         details: {
           items: [
             {
               statistic: 'Total DOM Elements',
               value: {
                 type: 'numeric',
                 granularity: 1,
-                value: 154,
+                value: 151,
               },
             },
             {