core(devtools-model): fix missing Runtime.experiments object (#3514)

GoogleChrome · Oct 9, 2017 · b98e8a3 · b98e8a3
1 parent 87c3acf
commit b98e8a3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lighthouse-core/lib/traces/devtools-timeline-model.js b/lighthouse-core/lib/traces/devtools-timeline-model.js
@@ -36,11 +36,14 @@ class TimelineModel {
     // populate with events
     this._tracingModel.reset();
 
-    ConsoleQuieter.mute({prefix: 'timelineModel'});
-    this._tracingModel.addEvents(events);
-    this._tracingModel.tracingComplete();
-    this._timelineModel.setEvents(this._tracingModel);
-    ConsoleQuieter.unmuteAndFlush();
+    try {
+      ConsoleQuieter.mute({prefix: 'timelineModel'});
+      this._tracingModel.addEvents(events);
+      this._tracingModel.tracingComplete();
+      this._timelineModel.setEvents(this._tracingModel);
+    } finally {
+      ConsoleQuieter.unmuteAndFlush();
+    }
 
     return this;
   }

diff --git a/lighthouse-core/lib/web-inspector.js b/lighthouse-core/lib/web-inspector.js
@@ -26,6 +26,10 @@ module.exports = (function() {
 
   global.Runtime = global.Runtime || {};
 
+  // Required for devtools-timeline-model
+  global.Runtime.experiments = global.Runtime.experiments || {};
+  global.Runtime.experiments.isEnabled = global.Runtime.experiments.isEnabled || (_ => false);
+
   const _queryParam = global.Runtime.queryParam;
   global.Runtime.queryParam = function(arg) {
     switch (arg) {