Skip to content

Commit

Permalink
tests(smoke): use major milestone (#14104)
Browse files Browse the repository at this point in the history
  • Loading branch information
adamraine authored Jun 8, 2022
1 parent e0a29d1 commit c463c4e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ const expectations = {
// Test that the numbers for individual elements are in the ballpark.
// Exact ordering and IDs between FR and legacy differ, so fork the expectations.
'4-11-IMG': {
_minChromiumVersion: '104.0.5100.0',
_minChromiumVersion: '104',
_legacyOnly: true,
top: '650±50',
bottom: '650±50',
Expand All @@ -443,7 +443,7 @@ const expectations = {
},
// Legacy runner execution context ID changed after 104.0.5100.0
'5-11-IMG': {
_maxChromiumVersion: '104.0.5098.0',
_maxChromiumVersion: '103',
_legacyOnly: true,
top: '650±50',
bottom: '650±50',
Expand Down
12 changes: 6 additions & 6 deletions lighthouse-cli/test/smokehouse/test-definitions/screenshot.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ const expectations = {
// Note: The first number (5) in these ids comes from an executionContextId, and has the potential to change.
// The following P is the same element as above but from a different JS context. This element
// starts with height ~18 and grows over time. See screenshot.html.
'5-0-BODY': {_legacyOnly: true, ...elements.body, _maxChromiumVersion: '104.0.5098.0'},
'5-2-P': {_legacyOnly: true, ...elements.p, _maxChromiumVersion: '104.0.5098.0'},
'5-3-HTML': {_legacyOnly: true, _maxChromiumVersion: '104.0.5098.0'},
'5-0-BODY': {_legacyOnly: true, ...elements.body, _maxChromiumVersion: '103'},
'5-2-P': {_legacyOnly: true, ...elements.p, _maxChromiumVersion: '103'},
'5-3-HTML': {_legacyOnly: true, _maxChromiumVersion: '103'},
// Legacy runner execution context ID changed after 104.0.5100.0
'4-0-BODY': {_legacyOnly: true, ...elements.body, _minChromiumVersion: '104.0.5100.0'},
'4-2-P': {_legacyOnly: true, ...elements.p, _minChromiumVersion: '104.0.5100.0'},
'4-3-HTML': {_legacyOnly: true, _minChromiumVersion: '104.0.5100.0'},
'4-0-BODY': {_legacyOnly: true, ...elements.body, _minChromiumVersion: '104'},
'4-2-P': {_legacyOnly: true, ...elements.p, _minChromiumVersion: '104'},
'4-3-HTML': {_legacyOnly: true, _minChromiumVersion: '104'},

// Fraggle rock should contain the same elements just with different ids.
'9-0-P': {_fraggleRockOnly: true, ...elements.p},
Expand Down

0 comments on commit c463c4e

Please sign in to comment.